Tulio Ruiz (b0f6eac3) at 23 Sep 17:51
[DEPRECATION] Deprecation message.
As we are migrating to vxci as first step to deprecate deployv thie repository is no longer needed
As we are migrating to vxci as first step to deprecate deployv thie repository is no longer needed
@moylop260 The message indicating that this repository is being deprecated, after this is merged I'll set the repository in maintenance / read only mode, what do you think?
As we are migrating to vxci as first step to deprecate deployv thie repository is no longer needed
Dummies:
Superseded by new vxci tool:
if chrome_version == "current"
Moy vs Moy: It should be linted!
Thank you for your feedback!
Prefer inline conditional. This to avoid setting the same variable twice when the condition is met and (using your own words) avoid increasing cyclomatic complexity
OS is used from current projects
So, it is dual compatibility
I mean, here you're treating "OS" the same as "current", which in MQT are very different. In MQT, current is the default, while OS was introduced as a workaround precisely to avoid an issue with the current version, by don't installing Chrome but keeping the version available in image (which was not Chrome but a standalone Chrome Headless AFAIK).
AFAIK, QFG is the only project using that workaround so far, the rest work correctly with current or pinnet in fault. So, I consider, instead of supporting OS, we should figure out what's the currently available version in MQT and pin Chrome to that version in QFG.
I'd like to note that we're currently migrating QFG from 13.0 to 15.0, and in 15.0 we're not using OS anymore. but fixing tests to don't break under that version. That was introduced only to don't have to change tests in current Odoo version but on the new one.
We realized yesterday the current projects migrated are skipping "chrome" tests
See the following log output:
cd.txt:4517:2022-09-09 19:50:33,880 461 INFO test odoo.addons.typ.tests.test_pos: skipped TestPos.test_01_run_tours
cd.txt:4519:2022-09-09 19:50:33,935 461 INFO test odoo.addons.typ.tests.test_website: skipped TestWebsite.test_01_lead_from_product
cd.txt:4521:2022-09-09 19:50:33,983 461 INFO test odoo.addons.typ.tests.test_website: skipped TestWebsite.test_02_address_creation_edit_remove
Related to reason 'Chrome executable not found'
The unitests could fail if a different version of chrome is used
So, a few projects has set a variable to use a particular version of chrome
All the projects already migrated has the dummy MR running correctly with this change (see main description)
It is ready
Could you review it, please?
I tried this way at first but it is not even working well for all images used
You can reproduced it using the following command:
docker run -it vauxoo/odoo-120-image /bin/bash -c "wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -O /tmp/chrome.deb && apt install /tmp/chrome.deb"
and you will see the following output:
The following packages have unmet dependencies:
google-chrome-stable : Depends: fonts-liberation but it is not installable
Depends: libasound2 (>= 1.0.17) but it is not installable
Depends: libatk-bridge2.0-0 (>= 2.5.3) but it is not installable
Depends: libatk1.0-0 (>= 2.2.0) but it is not installable
Depends: libatspi2.0-0 (>= 2.9.90) but it is not installable
Depends: libdrm2 (>= 2.4.60) but it is not installable
Depends: libgbm1 (>= 8.1~0) but it is not installable
Depends: libgtk-3-0 (>= 3.9.10) but it is not installable or
libgtk-4-1 but it is not installable
Depends: libpango-1.0-0 (>= 1.14.0) but it is not installable
Depends: libwayland-client0 (>= 1.0.2) but it is not installable
Depends: libxcomposite1 (>= 1:0.4.4-1) but it is not installable
Depends: libxdamage1 (>= 1:1.1) but it is not installable
Depends: libxfixes3 but it is not installable
Depends: libxkbcommon0 (>= 0.4.1) but it is not installable
Depends: libxrandr2 but it is not installable
Depends: xdg-utils (>= 1.0.2) but it is not installable
E: Unable to correct problems, you have held broken packages.
Chrome should be in the test image
This MR install chrome in the test image (based on production one)
if current, then do nothing, as the versiona vailable on the image should be up to date
This script do this too
If pinned, re-install it
This script do this too
- OS doesn't make much of a sense here, because that was to avoid an issue in MQT to use currrently-available version (Chrome Headless was available, but Chrome itself was not even installed)
OS is used from current projects
So, it is dual compatibility
Notice the following example:
So, we need to support it even if it doesn't have sense
It will avoid raising new errors
What do you think about using apt to install the deb package? That way, both the package and its dependnecies should be installed
"apt install /tmp/chrome.deb",
I think it should go like this:
Dummies:
Tulio Ruiz (48248755) at 08 Sep 21:25
[IMP] common: add support for coverage minimum and precision
It's now possible to control the following parameters using environment variables:
$COVERAGE_MIN
$COVERAGE_PRECISION
When the above variables are not set , values will fallback to their defaults, i.e. 0.
This was already implemented in the old CI [1] and added to the project template [2].
For more information, please check the configuration reference of Coverage.py on [3].
[1] https://github.com/Vauxoo/maintainer-quality-tools/pull/314
[2] https://git.vauxoo.com/vauxoo/project-template/commit/93bd8c1d
[3] https://coverage.readthedocs.io/en/coverage-5.0/config.html